docs: remove deprecated disable-log-requests flag #22113
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated --disable-log-requests flag from various documentation files, example scripts, and benchmark configurations. The changes are consistent across all modified files and align with the goal of cleaning up deprecated usage. The modifications are correct and improve the maintainability of the codebase by keeping examples and documentation up-to-date. I have reviewed the changes and found no issues.
mergify
bot
added
documentation
ywang96
removed
documentation
mergify
bot
added
documentation
|
There are also files that incorrectly use |
ywang96
requested review from
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
Oh interesting - I've removed them in 354244c |
DarkLight1337
added
the
ready
| "argument '--disable-log-requests' is deprecated. This " | ||
| "will be removed in v0.12.0.") | ||
| "argument '--disable-log-requests' is deprecated and " | ||
| "replaced with '--enable-log-requests'. This will be " | ||
| "removed in v0.12.0.") |
There was a problem hiding this comment.
@hmellor Let me know if you're okay with this change!
There was a problem hiding this comment.
Yeah this is good. It more closely matches the warning from the engine classes
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me>
Summary
--disable-log-requestsflag from docs and examples